[tools] Capture unquoted pnpm catalog keys in dependabot changeset generator#14646
Conversation
|
|
Codeowners approval required for this PR:
Show detailed file reviewers |
|
The lazy quantifier works correctly here because the required My review findings:
One minor consideration: the PR body notes "Documentation not necessary — internal build tooling change" and the change is to a I found no logic bugs, security issues, or behavioral regressions. LGTM |
@cloudflare/autoconfig
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
16e03d3 to
7c2b61b
Compare
7c2b61b to
0b9c121
Compare
Describe your change...
Fixes the Dependabot changeset generator (
tools/dependabot/generate-dependabot-pr-changesets.ts) droppingworkerdfrom the auto-generated changelog.The
parseDiffForChanges()regex required dependency keys to be quoted (JSON style). In thepnpm-workspace.yamlcatalog,"@cloudflare/workers-types"is a quoted YAML key butworkerdis an unquoted YAML key, so it was silently skipped. This normally went unnoticed because Dependabot also bumps the quoted"workerd"pins inpackages/miniflare/package.json, so workerd got captured from there — but in #14642 Dependabot bumpedworkerdonly in the catalog, so it was missing from the generated changeset entirely.The regex now treats the quotes around the key as optional, capturing both
"workerd": "1.2.3"(JSON) andworkerd: "1.2.3"(unquoted YAML).