fix(wrangler): use lstat so the asset walker skips symlinks as intended#14643
Open
evilgensec wants to merge 8 commits into
Open
fix(wrangler): use lstat so the asset walker skips symlinks as intended#14643evilgensec wants to merge 8 commits into
lstat so the asset walker skips symlinks as intended#14643evilgensec wants to merge 8 commits into
Conversation
🦋 Changeset detectedLatest commit: 9126a1f The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Codeowners approval required for this PR:
Show detailed file reviewers
|
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The Workers and Pages asset walkers intend to skip symbolic links:
but they call
stat()first, which dereferences the symlink, soisSymbolicLink()always returnsfalse. As a result, symlinked entries inside an assets directory are followed and their targets are collected/uploaded as assets instead of being skipped. Per the Node docs,Stats.isSymbolicLink()is only meaningful afterlstat()(afterstat()the link has already been resolved).The fix
Switch both walkers to
lstat()so the existingisSymbolicLink()skip logic works as intended. No behavior change for regular files or directories.packages/deploy-helpers/src/deploy/helpers/assets.tspackages/wrangler/src/pages/validate.tsA changeset is included (patch for
wranglerand@cloudflare/deploy-helpers).