Skip to content

[wrangler] Add Flagship auto-provisioning#14640

Open
ericclemmons wants to merge 7 commits into
mainfrom
codex/flagship-autoprovision
Open

[wrangler] Add Flagship auto-provisioning#14640
ericclemmons wants to merge 7 commits into
mainfrom
codex/flagship-autoprovision

Conversation

@ericclemmons

@ericclemmons ericclemmons commented Jul 10, 2026

Copy link
Copy Markdown
Member

Enables https://developers.cloudflare.com/flagship/ bindings for automatic provisioning: https://developers.cloudflare.com/workers/wrangler/configuration/#automatic-provisioning


A picture of a cute animal (not mandatory, but encouraged)
🐯

@changeset-bot

changeset-bot Bot commented Jul 10, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 38f7c3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vite-plugin Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

✅ All changesets look good

@ask-bonk

ask-bonk Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

UnknownError: "Overloaded"

github run

@ask-bonk

ask-bonk Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

@ericclemmons Bonk workflow failed. Check the logs for details.

View workflow run · To retry, trigger Bonk again.

@pkg-pr-new

pkg-pr-new Bot commented Jul 10, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@14640

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@14640

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@14640

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@14640

miniflare

npm i https://pkg.pr.new/miniflare@14640

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@14640

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@14640

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@14640

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@14640

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@14640

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@14640

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@14640

wrangler

npm i https://pkg.pr.new/wrangler@14640

commit: 38f7c3a

ask-bonk[bot]

This comment was marked as resolved.

@ask-bonk

ask-bonk Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review posted successfully to PR #14640.

Summary of the actionable issue found:

Dry-run / inherit handling missing for draft flagship bindings (create-worker-upload-form.ts:436) — The new flagship branch omits the dryRun guard (app_id ??= INHERIT_SYMBOL) and the INHERIT_SYMBOL{ type: "inherit" } handling that every other provisionable binding (KV/R2/D1/AI Search/Agent Memory) implements. This breaks wrangler deploy --dry-run for exactly the draft-binding case the PR adds (throws "must have an app_id field"), and can serialize a Symbol into metadata via the FlagshipAppHandler.inherit()super.inherit() fallback path. Posted with a suggestion to mirror the existing pattern.

github run

@ericclemmons ericclemmons force-pushed the codex/flagship-autoprovision branch from 516e4ae to 1ac9b1b Compare July 10, 2026 15:46
@ericclemmons ericclemmons force-pushed the codex/flagship-autoprovision branch from 1ac9b1b to fa0b8f6 Compare July 10, 2026 20:26
@ericclemmons ericclemmons marked this pull request as ready for review July 10, 2026 21:35
@workers-devprod workers-devprod requested review from a team and edmundhung and removed request for a team July 10, 2026 21:36
@workers-devprod

Copy link
Copy Markdown
Contributor

Codeowners approval required for this PR:

  • @cloudflare/wrangler
Show detailed file reviewers
  • .changeset/blue-pandas-care.md: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/deploy/helpers/create-worker-upload-form.ts: [@cloudflare/wrangler]
  • packages/deploy-helpers/src/deploy/helpers/provision-bindings.ts: [@cloudflare/wrangler]
  • packages/miniflare/src/plugins/flagship/index.ts: [@cloudflare/wrangler]
  • packages/miniflare/test/plugins/flagship/index.spec.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/config/environment.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/config/validation.ts: [@cloudflare/wrangler]
  • packages/workers-utils/src/worker.ts: [@cloudflare/wrangler]
  • packages/workers-utils/tests/config/validation/normalize-and-validate-config.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/create-worker-upload-form/bindings.test.ts: [@cloudflare/wrangler]
  • packages/wrangler/src/tests/provision.test.ts: [@cloudflare/wrangler]

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

3 participants