fix: wrap AnalyticsEngine binding#155
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
dom96
left a comment
There was a problem hiding this comment.
Thank you for this! Any chance you could add a quick test for this too?
|
@dom96 Actually, we already have tests here: This is because And seems the CI tests also run on the local server: |
|
Ping @ryanking13 because #130 adds support for the Workers Analytics Engine. |
|
Yeah, it is tricky to test this as these classes sometimes have different class names in production and workerd dev environment. Thanks for catching this |
ryanking13
left a comment
There was a problem hiding this comment.
Looks good. Could you update the commit message to make the CI happy?
⧗ input: fix: Wrap AnalyticsEngine, which is used in production.
✖ subject may not end with full stop [subject-full-stop]
Close #154