chore: rearrange bindings and entrypoints classes#150
Open
ryanking13 wants to merge 1 commit into
Open
Conversation
ryanking13
changed the title
|
The refactor is clean. All code has been properly moved, all imports updated, the circular import problem is solved by co-locating LGTM |
dom96
approved these changes
Jul 14, 2026
dom96
left a comment
dom96
left a comment
Contributor
There was a problem hiding this comment.
Looks good, but see one suggestion
|
|
||
|
|
||
| # --------------------------------------------------------------------------- | ||
| # Binding wrappers |
Contributor
There was a problem hiding this comment.
Hmm, this implies to me that this should be in its own module. Perhaps move this into binding_wrappers.py? or similar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my last code refactor PR:
workers/_worker.py