Images binding: allow setting headers on .response()#6881
Open
Monark-Arkmon wants to merge 1 commit into
Open
Conversation
mglewis
approved these changes
Jul 13, 2026
jamesopstad
approved these changes
Jul 14, 2026
Merging this PR will improve performance by 9.69%
Performance Changes
Tip Curious why this is faster? Comment Comparing Footnotes
|
jasnell
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
response()now accepts an optionalheadersoption, so you can setCache-Control(or any other header) without manually rebuilding theResponse:content-typeis always taken from the transformed image and can't be overridden by a header you pass in.Before: you had to intercept the response, spread its headers, and rebuild it just to add one header:
After: pass the header straight to response():
This pairs nicely with Workers Cache, now that
Cache-Controlon the response is all you need to get a transform cached at the edge, it was a bit annoying to have to hand-roll headers just to set that one thing.Implemented as a generic
headers?: HeadersInitpassthrough rather than a Cache-Control-specific option, since the underlying problem (copying headers manually) applies to any header, not just cache-control.