ci: add Windows to the test matrix (verification phase)#1792
Draft
shulaoda wants to merge 2 commits into
Draft
Conversation
commit: |
8c52b8c to
9fbc48d
Compare
9fbc48d to
ff1dc9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Not for merge as-is. This PR is a verification harness for the Windows support effort: it runs the full test matrix on Windows for every PR so we can see and fix Windows failures on follow-up PRs. Once Windows is green, the matrix will be flipped to main-only (so PRs aren't slowed) and only then will the Windows matrix be merged.
Summary
windows-latestto theosmatrix of:test-unit,test-integration,test-integration-merge,create-next-app,e2e.blob-report-<os>-<shard>,coverage-html-<os>,playwright-report-<project>-<os>) so Windows and Linux runs don't collide.apt/sudo) withrunner.os == 'Linux'.Why run on PRs for now
The goal of this PR is to make Windows failures visible so they can be fixed incrementally. Running on PRs (not just main) lets each follow-up fix PR show its Windows status directly. The CI aggregate (
CI) will be red until the ~known Windows failures are resolved — that is expected during this phase.Switching to main-only before merge
Each test job's
os:is currently the static[ubuntu-latest, windows-latest]. To make Windows main-only (Linux-only on PRs) before merging, replace each with the gated form documented at the top of thejobs:block:Not included
wranglerones) are not excluded on Windows; failures there will be triaged on follow-up PRs rather than hidden.Notes / to verify before merge
mainis the aggregateCIjob (not individual matrix legs). Adding${{ matrix.os }}to leg names changes their display names; if branch protection required specific leg names, those would need updating. The existing shard-parameterized leg names suggest the gate is already theCIaggregate.