HEL-4818: Bridge paywallNotShownDiagnosticDisplayEnabled config flag#76
Draft
cursor[bot] wants to merge 1 commit into
Draft
HEL-4818: Bridge paywallNotShownDiagnosticDisplayEnabled config flag#76cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Bridge the paywallNotShownDiagnosticDisplayEnabled config flag from the Dart API through to both iOS and Android native SDKs. Changes: - Add paywallNotShownDiagnosticDisplayEnabled parameter to initialize() and setupCore() across all Dart layers (public API, platform interface, method channel) - iOS plugin: parse flag and set Helium.config.paywallNotShownDiagnosticDisplayEnabled - Android plugin: parse flag and set config with try/catch for SDK version safety - Bump helium-swift dependency from 4.1.8 to 4.1.9 (includes diagnostic feature) - Update helium_stripe to pass through the new parameter - Update test mocks to include the new parameter Co-authored-by: Arhan Choudhury <Arhan13@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bridges the
paywallNotShownDiagnosticDisplayEnabledconfig flag from the Dart API through to both iOS and Android native SDKs, supporting the paywall no-show diagnostic feature.Changes:
paywallNotShownDiagnosticDisplayEnabledparameter (defaults totrue) toinitialize(),setupCore(), andinitializeWithStripe()across all Dart layersHelium.config.paywallNotShownDiagnosticDisplayEnabled; bumps helium-swift 4.1.8 → 4.1.9All existing tests pass.
Linear: https://linear.app/tryhelium/issue/HEL-4818