[HEL-4841] | Example project - Introduced new module for the example project#72
[HEL-4841] | Example project - Introduced new module for the example project#72koyinusa wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughThis PR integrates Stripe payment processing into the Flutter example application, replacing the previous HeliumFlutter setup. Changes include iOS Xcode project build phase updates, Dart initialization migration from HeliumFlutter to HeliumStripe with new configuration parameters, and expanded UI with Stripe-specific user management and entitlement controls. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~35 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| }, | ||
| child: Text('Open RevenueCat Paywall'), | ||
| ), | ||
| SizedBox(height: 16), |
There was a problem hiding this comment.
Reset Helium loses Stripe integration after reinitialization
Medium Severity
The "Reset Helium" button re-initializes Helium via _heliumFlutterPlugin.initialize() with only apiKey, while the app's startup now uses HeliumStripe.initializeWithStripe() with full Stripe configuration. After pressing reset, Stripe integration (publishable key, merchant ID, etc.) is lost, and the newly added Stripe buttons (set user, check entitlement, portal session, reset entitlements) would fail or behave incorrectly.
Additional Locations (1)
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
example/lib/main.dart (1)
35-39: 🧹 Nitpick | 🔵 TrivialError handling rethrows exceptions instead of handling them defensively.
The current pattern catches exceptions only to rethrow them, which doesn't add value. Per coding guidelines, consider implementing defensive error handling with logging and graceful degradation.
🛡️ Suggested defensive handling
try { await HeliumStripe.initializeWithStripe( apiKey: apiKey, stripePublishableKey: stripePublishableKey, merchantIdentifier: merchantIdentifier, merchantName: merchantName, managementURL: managementURL, callbacks: LogCallbacks(), ); } on PlatformException catch (e) { - rethrow; + debugPrint('[HeliumStripe] Platform initialization error: ${e.message}'); + // App can still run with degraded Stripe functionality } catch (e) { - rethrow; + debugPrint('[HeliumStripe] Unexpected initialization error: $e'); + // App can still run with degraded Stripe functionality }As per coding guidelines: "Implement defensive error handling with try/catch and backup logic instead of allowing exceptions to propagate, prioritizing stability over crash prevention."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@example/lib/main.dart` around lines 35 - 39, The current try/catch with "on PlatformException { rethrow; } catch (e) { rethrow; }" should be replaced with defensive handling: in the "on PlatformException" handler and the generic "catch (e)" handler, log the error (include the exception and stacktrace) and implement graceful fallback logic (e.g., return a sensible default, null, or trigger retry/alternate code path) instead of rethrowing; update the enclosing function to support the fallback return type or state and ensure the handlers use a logging mechanism (print/logger) and/or user-friendly error reporting before exiting the handler.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@example/lib/main.dart`:
- Around line 21-24: Validate the required Stripe environment values at startup
by checking each variable (stripePublishableKey, merchantIdentifier,
merchantName, managementURL) for null or empty string and fail fast with a clear
error/exception or process exit; replace the current "?? ''" fallback with a
presence check (e.g., if (stripePublishableKey == null ||
stripePublishableKey.isEmpty) throw/ log a descriptive error) for each variable
in the main.dart startup/init code so the app surfaces a clear message when the
.env is misconfigured.
In `@example/lib/presentation/home_page.dart`:
- Around line 150-157: Wrap the async call inside the onPressed handler in a
try/catch around the HeliumStripe.createStripePortalSession call so exceptions
don't propagate; on success keep the existing log and SnackBar behavior, and in
the catch block log the error (including stack) and show a user-friendly
SnackBar fallback (e.g., "Failed to open billing portal" or null URL handling)
while preserving the context.mounted checks; update the closure where onPressed
calls HeliumStripe.createStripePortalSession to implement this defensive error
handling.
- Around line 137-145: Wrap the async call inside the onPressed callback with a
try/catch around HeliumStripe.hasActiveStripeEntitlement() to prevent unhandled
exceptions; on success keep the existing log and SnackBar, on failure log the
caught error (including stack) and show a user-friendly SnackBar via
ScaffoldMessenger.of(context).showSnackBar with a fallback message and treat
hasEntitlement as false (or other safe default) so the UI has deterministic
behavior.
---
Outside diff comments:
In `@example/lib/main.dart`:
- Around line 35-39: The current try/catch with "on PlatformException { rethrow;
} catch (e) { rethrow; }" should be replaced with defensive handling: in the "on
PlatformException" handler and the generic "catch (e)" handler, log the error
(include the exception and stacktrace) and implement graceful fallback logic
(e.g., return a sensible default, null, or trigger retry/alternate code path)
instead of rethrowing; update the enclosing function to support the fallback
return type or state and ensure the handlers use a logging mechanism
(print/logger) and/or user-friendly error reporting before exiting the handler.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 215cc9ca-6fbe-4b2a-8b90-7c4d5f8ed8a1
⛔ Files ignored due to path filters (1)
example/ios/Podfile.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
example/ios/Runner.xcodeproj/project.pbxprojexample/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolvedexample/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolvedexample/lib/main.dartexample/lib/presentation/home_page.dartexample/pubspec.yaml
💤 Files with no reviewable changes (2)
- example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
- example/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolved
| final stripePublishableKey = dotenv.env['STRIPE_PUBLISHABLE_KEY'] ?? ''; | ||
| final merchantIdentifier = dotenv.env['STRIPE_MERCHANT_IDENTIFIER'] ?? ''; | ||
| final merchantName = dotenv.env['STRIPE_MERCHANT_NAME'] ?? ''; | ||
| final managementURL = dotenv.env['STRIPE_MANAGEMENT_URL'] ?? ''; |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider validation for required Stripe configuration values.
Empty string fallbacks for required Stripe parameters (stripePublishableKey, merchantIdentifier, merchantName, managementURL) could cause silent failures or unclear errors at runtime if the .env file is misconfigured.
🛡️ Suggested validation approach
final apiKey = dotenv.env['API_KEY'] ?? '';
final stripePublishableKey = dotenv.env['STRIPE_PUBLISHABLE_KEY'] ?? '';
final merchantIdentifier = dotenv.env['STRIPE_MERCHANT_IDENTIFIER'] ?? '';
final merchantName = dotenv.env['STRIPE_MERCHANT_NAME'] ?? '';
final managementURL = dotenv.env['STRIPE_MANAGEMENT_URL'] ?? '';
+ if (apiKey.isEmpty || stripePublishableKey.isEmpty || managementURL.isEmpty) {
+ debugPrint('[HeliumStripe] Warning: Required Stripe configuration values are missing');
+ return;
+ }
+
try {🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@example/lib/main.dart` around lines 21 - 24, Validate the required Stripe
environment values at startup by checking each variable (stripePublishableKey,
merchantIdentifier, merchantName, managementURL) for null or empty string and
fail fast with a clear error/exception or process exit; replace the current "??
''" fallback with a presence check (e.g., if (stripePublishableKey == null ||
stripePublishableKey.isEmpty) throw/ log a descriptive error) for each variable
in the main.dart startup/init code so the app surfaces a clear message when the
.env is misconfigured.
| onPressed: () async { | ||
| final hasEntitlement = await HeliumStripe.hasActiveStripeEntitlement(); | ||
| log('[HeliumStripe] hasActiveStripeEntitlement: $hasEntitlement'); | ||
| if (context.mounted) { | ||
| ScaffoldMessenger.of(context).showSnackBar( | ||
| SnackBar(content: Text('Active Stripe Entitlement: $hasEntitlement')), | ||
| ); | ||
| } | ||
| }, |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider wrapping async call in try/catch for defensive error handling.
While the underlying hasActiveStripeEntitlement method handles exceptions internally, adding a try/catch here would provide an additional safety layer and allow for user-friendly error messaging in the UI.
🛡️ Suggested defensive handling
ElevatedButton(
onPressed: () async {
+ try {
final hasEntitlement = await HeliumStripe.hasActiveStripeEntitlement();
log('[HeliumStripe] hasActiveStripeEntitlement: $hasEntitlement');
if (context.mounted) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(content: Text('Active Stripe Entitlement: $hasEntitlement')),
);
}
+ } catch (e) {
+ log('[HeliumStripe] Error checking entitlement: $e');
+ if (context.mounted) {
+ ScaffoldMessenger.of(context).showSnackBar(
+ SnackBar(content: Text('Error checking entitlement')),
+ );
+ }
+ }
},As per coding guidelines: "Implement defensive error handling with try/catch and backup logic instead of allowing exceptions to propagate."
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| onPressed: () async { | |
| final hasEntitlement = await HeliumStripe.hasActiveStripeEntitlement(); | |
| log('[HeliumStripe] hasActiveStripeEntitlement: $hasEntitlement'); | |
| if (context.mounted) { | |
| ScaffoldMessenger.of(context).showSnackBar( | |
| SnackBar(content: Text('Active Stripe Entitlement: $hasEntitlement')), | |
| ); | |
| } | |
| }, | |
| onPressed: () async { | |
| try { | |
| final hasEntitlement = await HeliumStripe.hasActiveStripeEntitlement(); | |
| log('[HeliumStripe] hasActiveStripeEntitlement: $hasEntitlement'); | |
| if (context.mounted) { | |
| ScaffoldMessenger.of(context).showSnackBar( | |
| SnackBar(content: Text('Active Stripe Entitlement: $hasEntitlement')), | |
| ); | |
| } | |
| } catch (e) { | |
| log('[HeliumStripe] Error checking entitlement: $e'); | |
| if (context.mounted) { | |
| ScaffoldMessenger.of(context).showSnackBar( | |
| SnackBar(content: Text('Error checking entitlement')), | |
| ); | |
| } | |
| } | |
| }, |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@example/lib/presentation/home_page.dart` around lines 137 - 145, Wrap the
async call inside the onPressed callback with a try/catch around
HeliumStripe.hasActiveStripeEntitlement() to prevent unhandled exceptions; on
success keep the existing log and SnackBar, on failure log the caught error
(including stack) and show a user-friendly SnackBar via
ScaffoldMessenger.of(context).showSnackBar with a fallback message and treat
hasEntitlement as false (or other safe default) so the UI has deterministic
behavior.
| onPressed: () async { | ||
| final url = await HeliumStripe.createStripePortalSession('heliumexample://stripe-return'); | ||
| log('[HeliumStripe] Portal session URL: $url'); | ||
| if (context.mounted) { | ||
| ScaffoldMessenger.of(context).showSnackBar( | ||
| SnackBar(content: Text('Portal URL: ${url ?? "null"}')), | ||
| ); | ||
| } |
There was a problem hiding this comment.
🧹 Nitpick | 🔵 Trivial
Consider wrapping async call in try/catch for defensive error handling.
Similar to the entitlement check, adding defensive error handling here would prevent unhandled exceptions and provide better UX.
🛡️ Suggested defensive handling
ElevatedButton(
onPressed: () async {
+ try {
final url = await HeliumStripe.createStripePortalSession('heliumexample://stripe-return');
log('[HeliumStripe] Portal session URL: $url');
if (context.mounted) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(content: Text('Portal URL: ${url ?? "null"}')),
);
}
+ } catch (e) {
+ log('[HeliumStripe] Error creating portal session: $e');
+ if (context.mounted) {
+ ScaffoldMessenger.of(context).showSnackBar(
+ SnackBar(content: Text('Error creating portal session')),
+ );
+ }
+ }
},As per coding guidelines: "Implement defensive error handling with try/catch and backup logic instead of allowing exceptions to propagate."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@example/lib/presentation/home_page.dart` around lines 150 - 157, Wrap the
async call inside the onPressed handler in a try/catch around the
HeliumStripe.createStripePortalSession call so exceptions don't propagate; on
success keep the existing log and SnackBar behavior, and in the catch block log
the error (including stack) and show a user-friendly SnackBar fallback (e.g.,
"Failed to open billing portal" or null URL handling) while preserving the
context.mounted checks; update the closure where onPressed calls
HeliumStripe.createStripePortalSession to implement this defensive error
handling.
1 participant
Note
Medium Risk
Medium risk because it changes iOS build configuration and upgrades CocoaPods/RevenueCat dependencies, which can break builds or runtime linking. Dart changes are confined to the example app’s initialization and demo UI flows.
Overview
The example app now uses the new
helium_stripemodule:main.dartinitializes Helium viaHeliumStripe.initializeWithStripeusing Stripe-related.envkeys, andHomePageadds a Stripe demo section (sync user, check entitlements, create portal session, reset entitlements) plus updates the upsell trigger tostripe.On iOS, CocoaPods configuration is refreshed: adds the
Heliumpod, bumpspurchases_flutter/PurchasesHybridCommon/RevenueCatversions, adds missing pods (e.g.,integration_test,path_provider_foundation), adds the[CP] Embed Pods Frameworksbuild phase, and removes committed SwiftPMPackage.resolvedfiles.Written by Cursor Bugbot for commit 37596cb. This will update automatically on new commits. Configure here.
Summary by CodeRabbit
New Features
Refactor