CLDYCON-7039: Add rbac.clusterRole.allowKubeProxy - #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a value to the helm chart which wraps the "nodes/proxy" permission to address an unaddressed vulnerability
Where should the reviewer start?
Should be relatively small, just a test on the helm chart install/node retrieval process
How should this be manually tested?
Must be using the helm chart to deploy
Any background context you want to provide?
Kubernetes has (at the time) said this is working as intended, so we need to add a fix
What picture best describes this PR (optional but encouraged)?
What are the relevant Github Issues?
Developer Done List
For the Reviewer:
By approving this PR, the reviewer acknowledges that they have checked all items in this done list.
Reviewer/Approval Done List