Skip to content

Adjust for feedback from PR#18999#7

Merged
clokep merged 6 commits into
clokep:psycopg3from
jason-famedly:jason/adjust-for-feedback
Feb 19, 2026
Merged

Adjust for feedback from PR#18999#7
clokep merged 6 commits into
clokep:psycopg3from
jason-famedly:jason/adjust-for-feedback

Conversation

@jason-famedly

Copy link
Copy Markdown

Requires #6

@jason-famedly jason-famedly force-pushed the jason/adjust-for-feedback branch from e95f354 to 088ead3 Compare February 2, 2026 11:24
@jason-famedly jason-famedly force-pushed the jason/adjust-for-feedback branch from d826e4f to fec0746 Compare February 3, 2026 16:33
@jason-famedly jason-famedly force-pushed the jason/adjust-for-feedback branch from fec0746 to 4cd7924 Compare February 18, 2026 22:40
…ged libpq5 having Postgres 18 support which breaks previous versions of psycopg when compiled
@jason-famedly

Copy link
Copy Markdown
Author

Fascinating that the trial psycopg test had a fluke failure:

[FAIL]
Traceback (most recent call last):
  File "/home/runner/work/synapse/synapse/tests/rest/admin/test_user.py", line 5785, in test_redact_messages_all_rooms
    self.fail("Timed out waiting for redactions.")
twisted.trial.unittest.FailTest: Timed out waiting for redactions.

tests.rest.admin.test_user.UserRedactionBackgroundTaskTestCase.test_redact_messages_all_rooms

It appears this test is utilizing time.time() to check the timeout. Unfortunately, this is considered a flake as using fake time and real time in a test is automatically suspect when any kind of contention is happening(and is beyond the scope of what we are trying to accomplish)

@jason-famedly jason-famedly marked this pull request as ready for review February 19, 2026 15:34
@jason-famedly jason-famedly force-pushed the jason/adjust-for-feedback branch from 4438c67 to d94d4c0 Compare February 19, 2026 15:37
@clokep clokep merged commit 73415a2 into clokep:psycopg3 Feb 19, 2026
42 of 43 checks passed
@jason-famedly jason-famedly deleted the jason/adjust-for-feedback branch February 19, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants