Use owo-colors instead of colored#5029
Closed
onx2 wants to merge 2 commits into
Closed
Conversation
onx2
commented
May 15, 2026
|
|
||
| loop { | ||
| let readline = rl.readline(&format!("🪐{}>", &database).green()); | ||
| let readline = rl.readline(&format!("🪐{}>", &database).green().to_string()); |
Contributor
Author
There was a problem hiding this comment.
Macros like format and println are ok with anything that impl Display but this readline needs a &str so we need to first call to_string to convert unlike before which was automatically alloc a string for us.
Collaborator
|
See the comment here: #5028 (comment) |
Contributor
Author
Understood, I appreciate the review. Just to clarify for future reference, is the policy generally to avoid swapping out working deps for std lib or more optimized alternatives (e.g., zero-allocation, fewer dependencies, etc) to avoid code churn? I respect that, just want to make sure I know what to focus on next time. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Replaces direct usage of
coloredwithowo-colorsin the CLI and update crates.owo-colorsprovides similar styling ergonomics while avoidingcolored'slazy_staticdependency. It is also zero-allocation for common styling operations, so slightly faster, and has a smaller implementation footprint.API and ABI breaking changes
None.
Expected complexity level and risk
1
This is a small dependency and import replacement for terminal styling in CLI-facing output.
Testing
cargo check -p spacetimedb-cli -p spacetimedb-update