Add recursive mounts for submodules [Namespaces Part 1]#4990
Open
Add recursive mounts for submodules [Namespaces Part 1]#4990
Conversation
aasoni
changed the title
aasoni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Add a recursive
mountsfields to ModuleDef that references submodules.API and ABI breaking changes
This should not be a breaking change. However new V10 modules that are built with this change will not be publishable to older hosts as the new field won't be recognized.
Expected complexity level and risk
2
Testing
Mostly tested using ci tests. Will be tested more thoroughly in the typescript PR that will use the new mounts field.