Export ANSI Escape Sequence Length Functions - #52
Open
engmtcdrm wants to merge 7 commits into
Open
Conversation
Owner
|
Seems reasonable, will have a look over the weekend. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stems from looking around at how the graphemes package works while working on a terminal prompt package. I noticed that you have logic for identifying if a string/bytes are an ANSI escape sequence however it isn't exported. I want to be able to use it when parsing user input. I currently parse into graphemes with the graphemes package, but I cannot use the ANSI escape sequence booleans because of how i process input. My input buffer may chop the escape sequence into two passes if the escape sequence is at the end of the buffer's size. I think these functions are well fleshed out and others would find them useful.