fix(update): include <sys/wait.h> for WIFEXITED/WEXITSTATUS (Linux build)#209
Merged
Conversation
lib/update.cpp used the wait-status macros but relied on a transitive include that exists on FreeBSD but not on Linux, breaking the Linux build. Add the explicit POSIX include, as every other user of these macros in lib/ already does. https://claude.ai/code/session_01X6t6tzVypHye5bDGLxzmZK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
lib/update.cppuses the wait-status macrosWIFEXITED/WEXITSTATUSbut relied on a transitive include that exists on FreeBSD yet not on Linux, breaking the Linux build:Fix: add the explicit POSIX
#include <sys/wait.h>, placed in the system-header group exactly as every other user of these macros inlib/already does (run.cpp,jail_query.cpp,run_jail.cpp,util.cpp,zfs_ops.cpp,stack.cpp,console.cpp).Verification
WIFEXITED/WEXITSTATUSresolve via<sys/wait.h>✅update.cppend-to-end (with a stubrang.hpp, since the vendored header is absent in the Linux sandbox) ✅2-line change, no behavior change.
https://claude.ai/code/session_01X6t6tzVypHye5bDGLxzmZK
Generated by Claude Code