feat: skeleton of card cmd, without db interaction#6
Draft
NoeTerrier wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
I need a review on this beginning of skeleton for the |
Lumycea
reviewed
Jun 8, 2024
Lumycea
left a comment
Lumycea
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me overall. If you want to test, there is a test token on in the vault you can use to run a bot locally.
Comment on lines
+52
to
+58
| let is_at_office = cartd_status == "CLIC"; | ||
| let (text, token) = if is_at_office {("Donner la carte", "give_card")} else {("Rendre la carte", "return_card")}; | ||
|
|
||
| let row = vec![ | ||
| InlineKeyboardButton::callback(text, token), | ||
| InlineKeyboardButton::callback("Cancel", "nothing") | ||
| ]; |
Contributor
There was a problem hiding this comment.
I think it would be good to also have the possibility to "forward" the card, e.g. when a commission holds it, they can give it to another one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3