hotfix/cp-11915-missing-proguard-rule-for-notificationserviceextension#360
Open
unnaticleverpush wants to merge 2 commits into
Open
Conversation
Added a Proguard rule for `NotificationServiceExtension`.
There was a problem hiding this comment.
1 issue found across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a Proguard rule for
NotificationServiceExtension.Note
Medium Risk
Touches push subscription/token registration and consumer shrinker rules; incorrect handling could affect FCM retries, but the ProGuard change is narrowly scoped to extension implementations.
Overview
Fixes release/minified integrations where app-defined
NotificationServiceExtensionimplementations could be stripped, breaking custom notification handling (CP-11915). Adds an explicit consumer ProGuard-keeprule for classes implementing that interface.SubscriptionManagerFCMnow treatsTasks.awaitfailures fromFirebaseMessaging.getToken()explicitly: restores interrupt status onInterruptedException, maps nestedSERVICE_NOT_AVAILABLE**ExecutionException**s toIOExceptionfor existing retry/backoff, and logs other failures before falling back toFirebaseInstanceId.Build tooling: root
compileSdkVersion34, Kotlin 1.9.22, and the example app appliesorg.jetbrains.kotlin.androidwithcompileSdkVersion34.Reviewed by Cursor Bugbot for commit 15643d6. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by cubic
Add a consumer ProGuard rule to keep
NotificationServiceExtension, fixing release builds where the extension was stripped and notifications failed. Also hardens FCM token handling and updates build config for SDK 34. Addresses Linear CP-11915.Bug Fixes
com.cleverpush.NotificationServiceExtensionin consumer ProGuard rules.SubscriptionManagerFCM, handleInterruptedException(preserve interrupt) andExecutionExceptionfromFirebaseMessaging.getToken(); map nested "SERVICE_NOT_AVAILABLE" toIOExceptionand log others.Dependencies
compileSdkVersionto 34 andkotlinVersionto 1.9.22.org.jetbrains.kotlin.androidplugin in the example app.Written for commit 15643d6. Summary will update on new commits.