feat(scimdirectory): add credentials method for pull-provider directories - #579
Merged
gabrielmeloc22 merged 3 commits intoJul 23, 2026
Conversation
Co-authored-by: nicolas lopes <57234795+NicolasLopes7@users.noreply.github.com>
…ename The e0a3c51 rename of Client.Credentials -> AddCredentials left the generated package-level wrapper in api.go and the client test calling the old method, which broke the build (and lint/test in CI). Regenerate api.go and update the test to the new name.
gabrielmeloc22
deleted the
gabriel/orgs-1480-google-directory-api-adapter-full-sync-dapi
branch
July 23, 2026 23:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
Credentialsmethod to thescimdirectoryclient for uploading pull-provider credentials (e.g. a Google service-account key + subject email) to a directory. Backs the BAPI credentials endpoint used to enable pull-based directories.Changes
CredentialsParams{ServiceAccountJSON, SubjectEmail}andClient.Credentials(ctx, id, params)→POST /scim_directories/{id}/credentials, returning the updatedSCIMDirectory.Credentialswrapper inapi.go.TestCredentialscovering the request path and response mapping.