Skip to content

build: allow skipping publication signing for local publishing - #833

Merged
swolfand merged 1 commit into
mainfrom
mike/local-publish-signing-guard
Jul 30, 2026
Merged

build: allow skipping publication signing for local publishing#833
swolfand merged 1 commit into
mainfrom
mike/local-publish-signing-guard

Conversation

@mikepitre

@mikepitre mikepitre commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Problem

./gradlew publishToMavenLocal fails on signMavenPublication / signAndroidPublication unless Maven Central signing keys are configured, which no local dev machine has. That makes it needlessly hard to build consumers (like the Expo module) against a local clerk-android checkout — the workaround was commenting out signAllPublications() by hand.

What this adds

All three publishing modules (api, ui, telemetry) skip signAllPublications() when -PRELEASE_SIGNING_ENABLED=false is passed:

./gradlew publishToMavenLocal -PRELEASE_SIGNING_ENABLED=false

The property name follows the vanniktech maven-publish convention. Without the property, publications are signed exactly as before, so Maven Central releases are unaffected.

Modules

source/api, source/ui, source/telemetry — build scripts only, no source changes.

Testing

  • publishToMavenLocal -PRELEASE_SIGNING_ENABLED=false: all modules publish with no signing keys configured
  • publishToMavenLocal without the property: still fails with "no configured signatory" on this keyless machine, confirming default signing behavior is unchanged

🤖 Generated with Claude Code

Note

Skip publication signing for local publishing via RELEASE_SIGNING_ENABLED flag

Wraps signAllPublications() in a conditional check for the RELEASE_SIGNING_ENABLED Gradle property in api/build.gradle.kts, telemetry/build.gradle.kts, and ui/build.gradle.kts. Setting RELEASE_SIGNING_ENABLED=false skips signing, which is useful for local Maven publishing without requiring signing credentials.

Macroscope summarized 0fa451a.

Summary by CodeRabbit

  • Build & Publishing
    • Publication signing can now be disabled for local publishing by setting RELEASE_SIGNING_ENABLED=false.
    • Release publications continue to be signed by default.

publishToMavenLocal previously failed on the signing tasks unless Maven
Central signing keys were configured, which no local dev setup has. All
three publishing modules now skip signAllPublications() when
-PRELEASE_SIGNING_ENABLED=false is passed, so consumers (e.g. the Expo
module) can be built against a local SDK checkout with:

  ./gradlew publishToMavenLocal -PRELEASE_SIGNING_ENABLED=false

Default behavior is unchanged: without the property, publications are
signed exactly as before.
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 10180548-b083-4c57-93be-a7812e95873f

📥 Commits

Reviewing files that changed from the base of the PR and between a4f4847 and 0fa451a.

📒 Files selected for processing (3)
  • source/api/build.gradle.kts
  • source/telemetry/build.gradle.kts
  • source/ui/build.gradle.kts

📝 Walkthrough

Walkthrough

Maven publication signing in the API, telemetry, and UI modules is now conditional on the RELEASE_SIGNING_ENABLED Gradle property, allowing signing to be disabled for local publishing.

Changes

Publication signing

Layer / File(s) Summary
Conditional signing configuration
source/api/build.gradle.kts, source/telemetry/build.gradle.kts, source/ui/build.gradle.kts
Publication signing now runs unless RELEASE_SIGNING_ENABLED is explicitly set to "false", with comments documenting the local publishing override.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: swolfand

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: making publication signing skippable for local publishing.
Description check ✅ Passed The description covers the problem, change, affected modules, and testing, though it doesn't follow the template headings exactly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mike/local-publish-signing-guard

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mikepitre
mikepitre marked this pull request as ready for review July 30, 2026 04:11
@mikepitre
mikepitre requested a review from swolfand July 30, 2026 04:12

@swolfand swolfand left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just do it the old fashioned way want comment this stuff out when you want local builds

@swolfand
swolfand merged commit 8448077 into main Jul 30, 2026
17 checks passed
@swolfand
swolfand deleted the mike/local-publish-signing-guard branch July 30, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants