fix(ui): wire back button on sign-up code and collect-field screens - #823
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughBack-button handling is added to the themed authentication scaffolds in the sign-up code and field-collection views, delegating navigation to the authentication state. ChangesSign-up navigation
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
The back button on two sign-up screens renders but does nothing.
ClerkThemedAuthScaffold defaults to onBackPressed: () -> Unit = {} with hasBackButton: Boolean = true,
so any call site that omits onBackPressed draws a chevron that silently no-ops.
SignUpCodeView and SignUpCollectFieldView both omitted it — every other auth screen passes authState::navigateBack. System back/gesture works on these screens, which is why only the button appears broken.
Verified on samples/prebuilt-ui: back now returns from the code screen to auth start, and from the
create-password screen to the code screen. Sign-in flow unchanged.
PS: this issue of non-working back-button only effects android, because the verification chain is different between the two native platforms.
Note
[!NOTE]
Wire back button on sign-up code and collect-field screens
Passes
onBackPressedcallbacks wired toauthState.navigateBack()in SignUpCodeView.kt and SignUpCollectFieldView.kt. Previously, the back button had no effect on these screens.Macroscope summarized 5c715b3.
Summary by CodeRabbit