refactor: overhaul environment handling and server/client architecture - #400
Draft
wobsoriano wants to merge 1 commit into
Draft
refactor: overhaul environment handling and server/client architecture#400wobsoriano wants to merge 1 commit into
wobsoriano wants to merge 1 commit into
Conversation
wobsoriano
commented
Mar 4, 2026
wobsoriano
commented
Collaborator
- Remove all $env/dynamic imports for static adapter support
- Auto-read process.env in Node environments via withClerkHandler
- Namespace all Clerk page data under page.data.__clerk (via buildClerkProps)
- Augment App.PageData with __clerk automatically — zero user boilerplate
- Simplify root ClerkProvider to spread page.data.__clerk instead of listing all props
- clerkClient now accepts RequestEvent or App.Locals
- Remove client-only redirect URLs from middleware (signInForceRedirectUrl etc.) — users configure these directly on
- Remove __internal_clerkJSUrl/__internal_clerkJSVersion from public ClerkProviderProps matching the React SDK pattern (Omit<IsomorphicClerkOptions, keyof InternalClerkScriptProps>)
- Properly type localsConfig as ClerkSvelteKitMiddlewareOptions (no Record<string, any> casts)
- Use as unknown as ClerkOptions for clerk.load() matching the Vue SDK pattern
- Remove all $env/dynamic imports for static adapter support - Auto-read process.env in Node environments via withClerkHandler - Namespace all Clerk page data under page.data.__clerk (via buildClerkProps) - Augment App.PageData with __clerk automatically — zero user boilerplate - Simplify root ClerkProvider to spread page.data.__clerk instead of listing all props - clerkClient now accepts RequestEvent or App.Locals - Remove client-only redirect URLs from middleware (signInForceRedirectUrl etc.) — users configure these directly on <ClerkProvider> - Remove __internal_clerkJSUrl/__internal_clerkJSVersion from public ClerkProviderProps matching the React SDK pattern (Omit<IsomorphicClerkOptions, keyof InternalClerkScriptProps>) - Properly type localsConfig as ClerkSvelteKitMiddlewareOptions (no Record<string, any> casts) - Use as unknown as ClerkOptions for clerk.load() matching the Vue SDK pattern Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ Deploy Preview for svelte-clerk ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.