fix: saml enterprise sso sign in - #424
Open
Conversation
MarkOSullivan94
added
clerk_auth
MarkOSullivan94
marked this pull request as ready for review
June 25, 2026 15:52
Collaborator
Author
|
@sarkisdev can you confirm if this fixes the issues you were facing? I was able to sign in successfully with Okta after implementing these changes but if you are still noticing some problems please let me know and I'll investigate further |
MarkOSullivan94
force-pushed
the
421-enterprise-saml-sso-sign-in-never-completes-oauthsignin-drops-identifier-and-parsedeeplink-ignores-the-saml-verification-strategy
branch
from
June 25, 2026 16:08
81c444d to
57b897f
Compare
# Conflicts: # packages/clerk_flutter/test/unit/clerk_auth_state_test.dart
MarkOSullivan94
force-pushed
the
421-enterprise-saml-sso-sign-in-never-completes-oauthsignin-drops-identifier-and-parsedeeplink-ignores-the-saml-verification-strategy
branch
from
July 7, 2026 12:22
57b897f to
8aa534a
Compare
slightfoot
force-pushed
the
main
branch
2 times, most recently
from
July 16, 2026 21:23
71a3098 to
5dcfe4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #421
This pull request addresses two bugs related to SSO and SAML authentication flows, ensuring correct handling of the
identifierfor enterprise SSO sign-ins and proper SSO detection for SAML strategies. It adds new tests to verify these behaviors and refactors the sign-in panel logic to improve handling of enterprise SSO factors.Bug fixes and authentication logic improvements:
oauthSignInmethod now forwards theidentifierfrom the existingSignInobject when using theenterprise_ssostrategy, ensuring the server can resolve the correct SAML connection.isSSOgetter in theStrategyclass now treats thesamlstrategy as SSO, fixing issues where SAML-based sign-ins were not recognized as SSO.Sign-in panel logic refactor:
needsEnterpriseSSO) if enterprise SSO is required, and callsssoSignInafter the main sign-in attempt, improving control flow and error handling. [1] [2] [3]Testing and coverage:
oauthSignIncorrectly forwards theidentifierfor enterprise SSO, and thatparseDeepLinkcompletes sign-in when the verification strategy is SAML. Supporting test utilities for capturing HTTP requests are also included. [1] [2]isSSOgetter returnstruefor thesamlstrategy.Additional thoughts
As signing in with Okta requires interaction with a web view it would be a good idea if we could add a Patrol test for this entire flow to avoid future regressions in the future