fix resuming experiments#126
Merged
Merged
Conversation
A crashed mid-write previously left a corrupted CSV that resume could not parse. Both per-slide embedding updates and the post-tiling slide metadata recorder now write to a temp file and rename onto the target, so resume can always trust process_list.csv.
clemsgrs
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_list.csvpreviously left a corrupted CSV that resume could not parse, forcing slides to be re-processed even though their artifacts were on diskslide2vec.utils.tiling_io.atomic_write_dataframe_csv(temp file + atomic rename) and routes the two non-atomic writers through it:update_process_list_after_embedding(called per slide during embedding) andrecord_slide_metadata_in_process_list