Skip to content

parallelizing file existance check using promises#188

Open
maxlath wants to merge 2 commits into
claudioc:masterfrom
inventaire:patch-1
Open

parallelizing file existance check using promises#188
maxlath wants to merge 2 commits into
claudioc:masterfrom
inventaire:patch-1

Conversation

@maxlath

@maxlath maxlath commented Dec 30, 2016

Copy link
Copy Markdown
Contributor

Motivations:

If this sounds like good motivations, I can have a look at other places where fs.existsSync is used throughout the project :)

thanks for this great project!

@claudioc

claudioc commented Jan 8, 2017

Copy link
Copy Markdown
Owner

This is very good point. I like how this PR works and I definitely would like to merge it.

I propose that you try to kill all the exists, first if you want replacing them with a sync access and then if you feel comfortable with the code, move them to the promisified version.

What do you think? Thanks!

@maxlath

maxlath commented Jan 8, 2017

Copy link
Copy Markdown
Contributor Author

4d5495f focuses on killing all uses of fs.exists but mostly keeping the sync flow

@maxlath

maxlath commented Jan 8, 2017

Copy link
Copy Markdown
Contributor Author

Then, getting those to work async seems to require some heavy rewriting. That could make sense in an effort to get the whole project into promises flow but I can't give it the time in needs unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants