fix: allow feedback updates and surface submission state in UI - #72
Merged
Conversation
Two bugs: - Print endpoint was walking the packet JSON blob for artifacts, but artifacts are stored in the worksheet_artifacts DB table. Switch to list_packet_artifacts() like the manifest endpoint does. - HTML artifact downloads forced Content-Disposition: attachment, causing a file download instead of opening in the browser. HTML is now served inline (text/html + Content-Disposition: inline) for a seamless view-then-print workflow. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
260 words across 4 blend families (L, R, S, Final). 20% of words displayed with grapheme-chunk markup (blend in accent color + middle-dot separator). OpenDyslexic font, letter-size, auto-print on load. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Feedback was rejected with 400 when resubmitting for a packet that already had feedback. Also, the UI showed Provide Feedback regardless of whether feedback had been submitted. - packet_store: upsert feedback instead of INSERT-only; add has_feedback and feedback_completed_at to list_weekly_packets via LEFT JOIN - feedback_processor: add reverse_quantity_feedback to undo prior activity_bias before applying a corrected value - main: fetch existing feedback before processing; reverse old quantity effect when updating - frontend: surface has_feedback/feedback_completed_at in types; add getFeedback API call; pre-populate modal with existing values; show Edit Feedback vs Provide Feedback; lock after 3 weeks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
save_packet_feedbacknow upserts (UPDATE if exists, INSERT if not) instead of raising on duplicatereverse_quantity_feedbackundoes the prioractivity_biasadjustment before the corrected value is applied; mastery re-processing appends a correction entry to historylist_weekly_packetsLEFT JOINspacket_feedbackto surfacehas_feedbackandfeedback_completed_aton every packet summaryhas_feedback=true; mastery and quantity ratings are pre-populatedTest Plan
feedback_completed_atolder than 3 weeks — button reads "Feedback Submitted" and is disabled108 tests passing(excluding pre-existing phonics script test)🤖 Generated with Claude Code