Skip to content

Fix (ckeditor-paste-from-office): Support paste from WPS Office. Closes #2488.#10471

Closed
flairyu wants to merge 1 commit into
ckeditor:masterfrom
flairyu:i/2488
Closed

Fix (ckeditor-paste-from-office): Support paste from WPS Office. Closes #2488.#10471
flairyu wants to merge 1 commit into
ckeditor:masterfrom
flairyu:i/2488

Conversation

@flairyu
Copy link
Copy Markdown

@flairyu flairyu commented Sep 3, 2021

Suggested merge commit message (convention)

Fix (ckeditor-paste-from-office): Support paste from WPS Office. Closes #2488.


Additional information

Please confirm and merge, lot's of people need this to be fixed. thanks.

@Reinmar
Copy link
Copy Markdown
Member

Reinmar commented Sep 6, 2021

Thanks, @flairyu

In order to merge this PR, we need automated tests. While the code coverage may still be 100%, we want to be sure that the patch really works and that we won't break it in the future.

You can find information about CKE5's dev and testing env here: https://ckeditor.com/docs/ckeditor5/latest/framework/guides/contributing/development-environment.html

@Reinmar
Copy link
Copy Markdown
Member

Reinmar commented Sep 6, 2021

cc @ckeditor/qa-team Could you check this change?

@yoyo837
Copy link
Copy Markdown

yoyo837 commented Sep 14, 2021

Great fix.

@Mgsy
Copy link
Copy Markdown
Member

Mgsy commented Sep 14, 2021

I've tested the proposed solution and the fix works like a charm!

The example Word document without the fix:

...and after applying the fix:

Also, it seems to not break pasting from Word, so it looks good 👏 .

@yoyo837
Copy link
Copy Markdown

yoyo837 commented Sep 14, 2021

When can we merge this? Can't wait. 🚀

@Reinmar
Copy link
Copy Markdown
Member

Reinmar commented Sep 14, 2021

@yoyo837 The PR lacks a test. If someone could add at least one test for it, we can speed up the merge. If not, we need to schedule for it and it may take some so it would probably slip to the next month's release.

@yoyo837
Copy link
Copy Markdown

yoyo837 commented Sep 15, 2021

@yoyo837 The PR lacks a test. If someone could add at least one test for it, we can speed up the merge. If not, we need to schedule for it and it may take some so it would probably slip to the next month's release.

I will be happy to try to add one after reading https://ckeditor.com/docs/ckeditor5/latest/framework/guides/contributing/contributing.html#tests

@yoyo837
Copy link
Copy Markdown

yoyo837 commented Nov 19, 2023

A more complete PR is here #14039

@CKEditorBot
Copy link
Copy Markdown
Collaborator

There has been no activity on this PR for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the contribution, leave a comment or reaction under this PR.

@CKEditorBot
Copy link
Copy Markdown
Collaborator

We've closed your PR due to inactivity. While time has passed, the core of your contribution might still be relevant. If you're able, consider reopening a similar PR.

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

resolution:expired This issue was closed due to lack of feedback.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support for pasting content from WPS

5 participants