Don't add group with no (valid) elements#7
Open
vitchyr wants to merge 3 commits into
Open
Conversation
Do the recursive step first. Then check if the child element has anything. It may be the case that the child element has no valid children, in which case don't both appending this group.
Do the recursive step first. Then check if the child element has anything. It may be the case that the child element has no valid children, in which case don't both appending this group.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the commit message:
I ran into this problem after I tried running
svg_test.pyon a pdf generated from pdf2svg. It created a bunch of tags like the following:Although the invalid tag is successfully ignored in the recursive call to
append()via theelt_classcheck, this isn't handled by the parent group. I think the only problem occurs when a group element only has invalid children, so hence the added check. I'm not familiar with how this might affect other code, but it doesn't seem to break anything else in the code.