Skip to content

test: enable Linux CI for the platform-independent core (Seatbelt-guard fix) - #1

Merged
cjchanh merged 1 commit into
mainfrom
fix/linux-ci-seatbelt-guards
Jul 4, 2026
Merged

test: enable Linux CI for the platform-independent core (Seatbelt-guard fix)#1
cjchanh merged 1 commit into
mainfrom
fix/linux-ci-seatbelt-guards

Conversation

@cjchanh

@cjchanh cjchanh commented Jul 4, 2026

Copy link
Copy Markdown
Owner

Guard Seatbelt tests on sandbox-exec (not jail_available, which is True on any Docker host); gate the DRAFT Docker backend tests behind DEPONENT_TEST_DOCKER; re-add ubuntu-latest to the CI matrix. deponent/jail.py unchanged. macOS: 145 pass / 8 skip / 0 fail. Verifying the ubuntu job here. Spec 2618517.

…RAFT Docker tests behind DEPONENT_TEST_DOCKER; re-enable ubuntu CI for the platform-independent core

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c11cbdc038

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".



@unittest.skipUnless(_DOCKER.available(), "no Docker daemon — Docker backend stays DRAFT until verified")
@unittest.skipUnless(os.environ.get("DEPONENT_TEST_DOCKER") == "1", "Docker backend is DRAFT; set DEPONENT_TEST_DOCKER=1 to run")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Require Docker availability before enabling tests

When DEPONENT_TEST_DOCKER=1 is exported on a host where Docker is absent or the daemon is down, this decorator now enables the whole class even though _DOCKER.available() is false; each test then calls _DOCKER.run() and fails with infrastructure errors instead of the documented auto-skip behavior in this file. Keep the env opt-in in addition to the availability check, e.g. require both DEPONENT_TEST_DOCKER=1 and _DOCKER.available().

Useful? React with 👍 / 👎.

@cjchanh
cjchanh merged commit eee3d2e into main Jul 4, 2026
8 checks passed
@cjchanh
cjchanh deleted the fix/linux-ci-seatbelt-guards branch July 4, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant