test: enable Linux CI for the platform-independent core (Seatbelt-guard fix) - #1
Conversation
…RAFT Docker tests behind DEPONENT_TEST_DOCKER; re-enable ubuntu CI for the platform-independent core
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c11cbdc038
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| @unittest.skipUnless(_DOCKER.available(), "no Docker daemon — Docker backend stays DRAFT until verified") | ||
| @unittest.skipUnless(os.environ.get("DEPONENT_TEST_DOCKER") == "1", "Docker backend is DRAFT; set DEPONENT_TEST_DOCKER=1 to run") |
There was a problem hiding this comment.
Require Docker availability before enabling tests
When DEPONENT_TEST_DOCKER=1 is exported on a host where Docker is absent or the daemon is down, this decorator now enables the whole class even though _DOCKER.available() is false; each test then calls _DOCKER.run() and fails with infrastructure errors instead of the documented auto-skip behavior in this file. Keep the env opt-in in addition to the availability check, e.g. require both DEPONENT_TEST_DOCKER=1 and _DOCKER.available().
Useful? React with 👍 / 👎.
Guard Seatbelt tests on sandbox-exec (not jail_available, which is True on any Docker host); gate the DRAFT Docker backend tests behind DEPONENT_TEST_DOCKER; re-add ubuntu-latest to the CI matrix. deponent/jail.py unchanged. macOS: 145 pass / 8 skip / 0 fail. Verifying the ubuntu job here. Spec 2618517.