Skip to content

riverlea - fix checkbox-list in hackneybrook dark mode - #32389

Merged
totten merged 1 commit into
civicrm:6.1from
ufundo:riverlea-hackneybrook-darkmode-checkbox-list-rc
Mar 18, 2025
Merged

riverlea - fix checkbox-list in hackneybrook dark mode#32389
totten merged 1 commit into
civicrm:6.1from
ufundo:riverlea-hackneybrook-darkmode-checkbox-list-rc

Conversation

@ufundo

@ufundo ufundo commented Mar 17, 2025

Copy link
Copy Markdown
Contributor

Overview

Fix issue with checkbox-list colours in Hackney Brook dark mode. I think this got garbled somewhere along the lines of versions of #32209

Before

image

After

image

Technical details

The existing defintion of checkbox-list-col isn't doing anything, it's being overridden two lines below

@civibot

civibot Bot commented Mar 17, 2025

Copy link
Copy Markdown

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot Bot added the 6.1 label Mar 17, 2025
@ufundo
ufundo marked this pull request as ready for review March 17, 2025 13:59
@ufundo

ufundo commented Mar 17, 2025

Copy link
Copy Markdown
Contributor Author

Have also backported to 6.0 branch here #32388

CC @vingle @colemanw

@totten
totten merged commit 1de7e17 into civicrm:6.1 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants