Skip to content

[6.0] Riverlea - merge text-light and light-text - #32175

Closed
ufundo wants to merge 11 commits into
civicrm:6.0from
ufundo:riverlea-text-light-light-text-6.0
Closed

[6.0] Riverlea - merge text-light and light-text#32175
ufundo wants to merge 11 commits into
civicrm:6.0from
ufundo:riverlea-text-light-light-text-6.0

Conversation

@ufundo

@ufundo ufundo commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

6.0 version of #31994

cc @vingle

@civibot

civibot Bot commented Feb 20, 2025

Copy link
Copy Markdown

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot Bot added the 6.0 label Feb 20, 2025
@ufundo
ufundo marked this pull request as ready for review February 20, 2025 12:39
@ufundo

ufundo commented Feb 22, 2025

Copy link
Copy Markdown
Contributor Author

Similarly reinstating the crm-text-dark changes here.

@ufundo ufundo added the run-standalone Civibot should setup demos+tests for Standalone label Feb 22, 2025
@ufundo
ufundo force-pushed the riverlea-text-light-light-text-6.0 branch from 35b1454 to 4ac64ce Compare February 22, 2025 14:08
@ufundo

ufundo commented Feb 22, 2025

Copy link
Copy Markdown
Contributor Author

Noticed some issues with heading/warning text colours getting flipped (particular in dark mode). I think they are resolved now.

@ufundo

ufundo commented Feb 23, 2025

Copy link
Copy Markdown
Contributor Author

Closing this as have redirected the original PR to 6.0 now: #31994

@ufundo ufundo closed this Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.0 run-standalone Civibot should setup demos+tests for Standalone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant