QT5 support#65
Open
vyrus001 wants to merge 2 commits into
Open
Conversation
added 2 commits
December 13, 2017 01:37
Contributor
|
Hi @citronneur. I'm interested in seeing if this pull request is something you might get added in? I use RDPY in EyeWitness, and thanks to @vyrus001 I was looking into moving to pyqt5, but I'd also need RDPY updated as well. Just wanted to see if this was something you would review. Thanks for the help! |
|
@citronneur FWIW Qt4 is no longer supported upstream so PyQt4 is actively removed from the various linux distributions, it would be nice to have a version of rdpy based on Qt5 so that we can keep maintaining a Kali package for rdpy. For better cross-referencing, I'm pointing out that RedSiege/EyeWitness#301 is the eyewitness pull request adding Qt5 support to that software but which depends on this pull request. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved QT support to QT5, tested on OSX 10.12.6 (all dependancies acquired via homebrew) and gentoo-hardened