Skip to content

Issue 137: Use current working directory instead of system temp for b… - #139

Merged
gthomas2 merged 3 commits into
mainfrom
issue_137_phar_ci_build_docker_compose_fix2
Jun 29, 2026
Merged

Issue 137: Use current working directory instead of system temp for b…#139
gthomas2 merged 3 commits into
mainfrom
issue_137_phar_ci_build_docker_compose_fix2

Conversation

@gthomas2

Copy link
Copy Markdown
Collaborator

…uilding images as system temp does not always seem to work on servers

…uilding images as system temp does not always seem to work on servers

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI Docker image build flow to create its temporary build directory under the current working directory (instead of the system temp directory), addressing environments where sys_get_temp_dir() paths are unreliable.

Changes:

  • Use getcwd() as the primary base directory for generating the CI build directory.
  • Canonicalize the chosen base directory with realpath() before constructing the ci-build-* path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Service/Main.php Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread src/Service/Main.php Outdated
Comment thread src/Service/Main.php
@gthomas2
gthomas2 merged commit 5fb45e4 into main Jun 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants