SF: add non-fatal Director state as the final Saturday-SF task (after ReportCard)#370
Merged
Conversation
… ReportCard)
The Director (Layer C, Part II) runs as the FINAL Saturday-SF task, after a
SUCCESSFUL ReportCard, weighing the fresh Report Card v2 → an advisory
DirectorWeeklyActionPlan. Wiring:
WaitForWeeklySubstrateHealthCheck → ReportCard → Director → CheckShellRunNotify
- ReportCard SUCCESS Next → Director (feeds it the fresh card).
- ReportCard Catch → CheckShellRunNotify (skip the Director — no card to weigh).
- Director Next AND its own Catch → CheckShellRunNotify (non-fatal: an advisory
failure never breaks the run that produced the real trading artifacts).
- Invokes alpha-engine-evaluator-director:live with {date.$: $.run_date}.
FLAG-GATED: the function is a no-op (status=disabled) until DIRECTOR_ENABLED
is flipped on after a clean Saturday cycle.
SF-role IAM: no change — the existing alpha-engine-evaluator* invoke grant
already covers alpha-engine-evaluator-director (asserted by
test_sf_iam_lambda_grants::test_every_invoked_lambda_has_iam_grant).
Guardrail tests updated: substrate-check + friday-shell-run wiring now assert
the ReportCard→Director→notify path (both Director edges land on the notify
gate); payload registry adds "Director": {date.$}. 596 SF tests green.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Director (Layer C, Part II) as the final Saturday-SF task, after a successful
ReportCard, weighing the fresh Report Card v2 → an advisoryDirectorWeeklyActionPlan.Wiring
Next→ Director (feeds it the fresh card).Catch→ CheckShellRunNotify — skip the Director when there's no card to weigh.NextAND its ownCatch→ CheckShellRunNotify — non-fatal: an advisory failure never breaks the run that produced the real trading artifacts (director-plan §5).alpha-engine-evaluator-director:livewith{date.$: $.run_date}.status=disabled) untilDIRECTOR_ENABLEDis flipped on after a clean Saturday cycle — so wiring it now is dormant/safe.IAM
No SF-role change — the existing
function:alpha-engine-evaluator*invoke grant already coversalpha-engine-evaluator-director, asserted bytest_sf_iam_lambda_grants::test_every_invoked_lambda_has_iam_grant.Tests
test_sf_substrate_check_wiring+test_sf_friday_shell_run_wiring: now assert theReportCard → Director → notifypath (both Director edges land onCheckShellRunNotify).test_sf_payload_uniqueness: payload registry adds"Director": {date.$}.Pairs with evaluator #22 (the Director Lambda + IAM + deploy). The live Saturday-SF definition update is an operator step.
🤖 Generated with Claude Code