Skip to content

Add custom link handlers#790

Closed
Airyzz wants to merge 8 commits into
cinnyapp:devfrom
Airyzz:link-handlers
Closed

Add custom link handlers#790
Airyzz wants to merge 8 commits into
cinnyapp:devfrom
Airyzz:link-handlers

Conversation

@Airyzz

@Airyzz Airyzz commented Aug 28, 2022

Copy link
Copy Markdown

Description

Adds the ability to add a custom handler for links. Allows for handling matrix.to requests inside Cinny as per #778. It also attempts to invoke a function through Tauri, so Cinny desktop can register its own handlers

It also opens links in a new tab by default

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Related: cinnyapp/cinny-desktop#56

@Airyzz

Airyzz commented Sep 9, 2022

Copy link
Copy Markdown
Author

If #411 gets merged we can use this implementation for navigating to the correct room

@kfiven

kfiven commented May 22, 2024

Copy link
Copy Markdown
Member

#411 is closed beacause of #1633 as we have used react-router for navigation. Closing this one as it depend on #411.

@kfiven kfiven closed this May 22, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants