Skip to content

fix: use notification plugin#570

Open
Kruemmelspalter wants to merge 1 commit into
cinnyapp:mainfrom
Kruemmelspalter:fix-notifications
Open

fix: use notification plugin#570
Kruemmelspalter wants to merge 1 commit into
cinnyapp:mainfrom
Kruemmelspalter:fix-notifications

Conversation

@Kruemmelspalter

@Kruemmelspalter Kruemmelspalter commented Apr 2, 2026

Copy link
Copy Markdown

This makes desktop notifications work. For whatever reason, the cinny icon is shown when using new Notification("...") in the debug console, but not when triggered from the cinny app itself.

Also, requesting permission does nothing right now and the "Enable" button is always shown, this may be because the plugin makes window.Notification.requestPermission an async function and it's being called form sync code, but overriding it to be a sync function didn't help either.

@f-krause

Copy link
Copy Markdown

This feature would be greatly appreciated to be released soon!! :)

@kfiven

kfiven commented Apr 13, 2026

Copy link
Copy Markdown
Member

This feature would be greatly appreciated to be released soon!! :)

@f-krause https://github.com/cinnyapp/cinny-desktop/actions/runs/24305479149 Test it out on test build. From my testing, it did not fix it.

@Kruemmelspalter

Kruemmelspalter commented Apr 13, 2026

Copy link
Copy Markdown
Author

for me it works from cargo tauri dev on wayland/niri, but it doesn't when using cargo tauri build --no-bundle and then running the output binary 🤔

@Serizao

Serizao commented May 26, 2026

Copy link
Copy Markdown

On my side this modification seem be work : Serizao@566a83e

@Kruemmelspalter

Copy link
Copy Markdown
Author

ah, maybe Notification.requestPermission just doesn't do anything in dev mode but needs to be called in release mode

@Kruemmelspalter

Copy link
Copy Markdown
Author

yes, with this it should work now

@Kruemmelspalter

Copy link
Copy Markdown
Author

@kfiven idk why i can't request a review but this would be ready now i suppose

@Chr1s70ph

Copy link
Copy Markdown

I tested it with cargo tauri dev on MacOS and the issue was not fixed

@Kruemmelspalter

Copy link
Copy Markdown
Author

I don't have access to a mac so sadly I can't really test / diagnose / fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants