fix: use notification plugin#570
Conversation
1c95099 to
53aad49
Compare
|
This feature would be greatly appreciated to be released soon!! :) |
@f-krause https://github.com/cinnyapp/cinny-desktop/actions/runs/24305479149 Test it out on test build. From my testing, it did not fix it. |
|
for me it works from |
|
On my side this modification seem be work : Serizao@566a83e |
|
ah, maybe |
23a9f09 to
70f5f48
Compare
|
yes, with this it should work now |
70f5f48 to
ff8a6a0
Compare
|
@kfiven idk why i can't request a review but this would be ready now i suppose |
|
I tested it with |
|
I don't have access to a mac so sadly I can't really test / diagnose / fix that |
This makes desktop notifications work. For whatever reason, the cinny icon is shown when using
new Notification("...")in the debug console, but not when triggered from the cinny app itself.Also, requesting permission does nothing right now and the "Enable" button is always shown, this may be because the plugin makes
window.Notification.requestPermissionan async function and it's being called form sync code, but overriding it to be a sync function didn't help either.