Do not panic on duplicate keys#159
Merged
Merged
Conversation
Callers may create index.KeySets that contain duplicate keys. Do not panic if this is the case. The added test in the new part_index_test.go fails if applied without the change in part_index.go. Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
requested review from
derailed and
joamaki
and removed request for
a team
Member
Author
|
CI test passed, but looks like a PR from a fork has no access to setting PR comments? |
|
Original Cilium issue for reference: cilium/cilium#45758 |
joamaki
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Callers may create
index.KeySets that contain duplicate keys. Do not panic if this is the case.The added test in the new
part_index_test.gofails if applied without the change inpart_index.go.