job: Don't unset started when registry stops#77
Merged
Conversation
By setting 'started = false' any jobs added after the registry has stopped could get appended to the application lifecycle. This can be hit by having a job added before starting that tries to add a job at runtime. That job is stopped after the registry and thus has time to call JobGroup.Add. It is possible to deadlock by stopping at the same time: Hive.Stop has locked the lifecycle mutex and appending is not possible and if job tries to append to the lifecycle before its stop hook gets called it'll deadlock. There is no use-case for making the registry restartable so just remove setting started to false completely. Signed-off-by: Jussi Maki <jussi@isovalent.com>
pippolo84
approved these changes
Jun 9, 2026
pippolo84
left a comment
pippolo84
left a comment
Member
There was a problem hiding this comment.
There is no use-case for making the registry restartable so just remove setting started to false completely.
Agree, changes LGTM ✔️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By setting 'started = false' any jobs added after the registry has stopped could get appended to the application lifecycle.
This can be hit by having a job added before starting that tries to add a job at runtime. That job is stopped after the registry and thus has time to call JobGroup.Add. It is possible to deadlock by stopping at the same time: Hive.Stop has locked the lifecycle mutex and appending is not possible and if job tries to append to the lifecycle before its stop hook gets called it'll deadlock.
There is no use-case for making the registry restartable so just remove setting started to false completely.