Skip to content

shell: Fix error handling in interactive shell#73

Merged
joamaki merged 1 commit into
mainfrom
pr/joamaki/fix-shell-error-handling
May 26, 2026
Merged

shell: Fix error handling in interactive shell#73
joamaki merged 1 commit into
mainfrom
pr/joamaki/fix-shell-error-handling

Conversation

@joamaki

@joamaki joamaki commented May 26, 2026

Copy link
Copy Markdown
Contributor

interactiveShell() did not check for the <<error>> marker which caused it to wait for more input instead of returning to the prompt:

   example> aoeu
   <stdin>:0: aoeu unknown command<<error>>

Fix this by checking for <<error>> and treating it as an end marker in interactive shell.

interactiveShell() did not check for the <<error>> marker which caused
it to wait for more input instead of returning to the prompt:

   example> aoeu
   <stdin>:0: aoeu unknown command<<error>>

Fix this by checking for <<error>> and treating it as an end marker
in interactive shell.

Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki requested a review from a team as a code owner May 26, 2026 09:02
@joamaki joamaki requested review from bimmlerd and removed request for a team May 26, 2026 09:02

@bimmlerd bimmlerd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sane to me

@joamaki joamaki merged commit f689952 into main May 26, 2026
1 check passed
@joamaki joamaki deleted the pr/joamaki/fix-shell-error-handling branch May 26, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants