Fran TEST 29.04.2019#6
Open
fparrar wants to merge 2 commits into
Open
Conversation
rglepe
reviewed
May 1, 2019
rglepe
left a comment
rglepe
left a comment
Contributor
There was a problem hiding this comment.
Lo primero gracias por la github page facilita mucho la vida.
Buen ejercicio. Te hago algunos comentarios:
- Utiliza clases e id's para todas las etiquetas, aumenta la especificidad de los selectores.
- el título de la página mejor en un
h1,spanestá bastante desaconsejado, impide dar formatos adecuados a los elementos. - el enlace a la raíz del doc es "./"
- la propiedad
fontde la regla general está mal construida y no se está aplicando. Esto hace que el contenedor no llegue hasta el final de la página. Revisa siempre el inspector de la página. - en el contenedor no hace falta la propiedad background-image
- reglas redundantes: text-decoration.
- la regla de
figuredebería aparecer más abajo. - el
footerdebería romper el float con clear:both. Te sale bien porque al no caber en la línea se posiciona debajo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://fparrar.github.io/tests/m1/