Dani - test CSS#4
Open
neollob wants to merge 6 commits into
Open
Conversation
rglepe
reviewed
May 1, 2019
rglepe
left a comment
rglepe
left a comment
Contributor
There was a problem hiding this comment.
Buen ejercicio, aunque algunos aspectos son mejorables:
Falta h1
Falta elemento nav
Siempre semánticos mejor que divo span.
Echo a faltar también clases o id's se hace difícil identificar el contenedor.
Está bien usar pseudo-clases pero fíjate que complicas la lectura del documento. Un class o id permite seguir mejor el CSS.
Me gusta la compactación del CSS. Mejora la eficiencia del navegador.
Recuerda:
- Simplicidad
- Código autodocumentado
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.