Victor montaña#14
Open
vicmonfun wants to merge 1 commit into
Open
Conversation
rglepe
reviewed
May 1, 2019
rglepe
left a comment
rglepe
left a comment
Contributor
There was a problem hiding this comment.
el div navegacion no es necesario puedes hacer lo mismo con nav
el main no debe incluir al aside
la barra de navegación tiene propiedades incorrectas que hace que no se apliquen los estilos.
Desde que el layout de la página no se ha establecido de forma correcta, el resto de propiedades son difíciles de aplicar.
Mi consejo es que sigas los siguientes pasos:
- Estructura el html con semánticos y sin contenedores y valídalo en w3c validator.
- Comienza el css con los reset y propiedades generales a nivel del body.
- Después haz el layout de la página (medidas y posiciones). En este momento introduce los
divque necesites para posicionar los elementos. OJO!! Sólo los imprescindibles. - Una vez la página está estructurada comienza a dar formato a los detalles.
Si puedes vuelve a repetir de cero el test sin mirar la solución.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.