Héctor#12
Open
HectorCo wants to merge 2 commits into
Open
Conversation
added 2 commits
April 29, 2019 14:13
rglepe
reviewed
May 1, 2019
rglepe
left a comment
rglepe
left a comment
Contributor
There was a problem hiding this comment.
el elemento h1 no tiene el atributo href.
el elemento figcaption depende del elemento figure.
si puedes, utiliza otra etiqueta en lugar de span. En el footer podrías usar p.
propiedad padding: inherit no nos sirve de reset. Debería ser 0.
Falta la repetición de la imagen.
Falta flotar los elementos a alinear.
Falta el formato del footer
El html está bien estructurado pero tienes problemas que podrían resolverse con la validación del html.
Siempre has de tener en mente el elemento al que quieres dar formato y pensar qué es lo que quieres hacer en cada momento. Recuerda, primero el layout de la página luego los detalles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.