[cuda_xpu_alignment] Fix replication_pad{2d,3d} meta accepting negative output dims - #28
Draft
Stonepia wants to merge 1 commit into
Draft
[cuda_xpu_alignment] Fix replication_pad{2d,3d} meta accepting negative output dims#28Stonepia wants to merge 1 commit into
replication_pad{2d,3d} meta accepting negative output dims#28Stonepia wants to merge 1 commit into
Conversation
[cuda_xpu_alignment] Fix `replication_pad{2d,3d}` meta accepting negative output dims
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[cuda_xpu_alignment] Fix
replication_pad{2d,3d}meta accepting negative output dimsFixes https://github.com/intel-sandbox/agentic_xpu/issues/2
Root Cause: The TORCH_CHECK / torch._check for output dimensions in replication_pad2d and replication_pad3d uses || (or) instead of && (and). This means the check passes if ANY dimension is >= 1, when it should require ALL dimensions to be >= 1. When only one dimension is negative, the check passes and a tensor with negative dimensions is created, causing downstream failures in FakeTensor/torch.compile.
Diff stat: