Prettier pretty#3
Open
raphael-proust wants to merge 3 commits into
Open
Conversation
instead of `foo = bar` |> parse |> pretty |> `foo =\n bar =` we have `foo = bar` |> parse |> pretty |> `foo = bar` but also instead of `foo =\n bar =` |> parse |> pretty |> `foo =\n bar =` we have `foo =\n bar =` |> parse |> pretty |> `foo = bar`
raphael-proust
force-pushed
the
prettier-pretty
branch
from
1ea7955 to
875cd90
Compare
raphael-proust
commented
Feb 20, 2025
Comment on lines
+11
to
+13
| let rec is_empty (Fix t) = | ||
| KeyMap.is_empty t | ||
| || KeyMap.for_all (fun k v -> k = "" && is_empty v) t |
Collaborator
Author
There was a problem hiding this comment.
empty maps or maps with ""→empty are all considered empty
it means that the following ccl document (e.g.,) is empty
=
=
=
=
=
Comment on lines
-58
to
+66
| baz = | ||
| baz |
Collaborator
Author
There was a problem hiding this comment.
it makes the queries a bit better because you get the actual value of the config, not a ccl document that encodes the actual value via a singleton key-nullvalue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is
a. on top of #2
b. possibly controversial (see comments)