feat(farmingcontract): add Farming Contracts plugin#495
Open
runsonmypc wants to merge 3 commits into
Open
Conversation
Automates Jane's farming contracts end to end: gets (and optionally downgrades) contracts, banks tools/seeds/compost, plants and harvests across patch types, clears and replants trees by paying the guild gardeners, and turns in completed contracts. Correctness details worth noting: - itemQuantity (not count) for stackable coins/seeds; count() returns the slot count, which caused false "1 coin" / banking loops - pay guild gardeners Rosie/Nikkie by name + tree-specific action when no generic "Pay" NPC is present, so checked/old trees get cleared - detect check-healthed trees via the "Chop down" action and clear them - guard auto-downgrade on needsDowngrade to stop re-downgrade loops - re-rake weeds that regrow during composting and confirm a seed was consumed before reporting a successful plant
Use the Guildmaster Jane chathead as the icon and card; wire up iconUrl/cardUrl in the descriptor. Bump version 0.2.1 -> 0.2.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Farming Contracts plugin that automates Jane's farming contracts in the Farming Guild end to end.
What it does
Correctness details
itemQuantityrather thancountfor coins/seeds —count()returns the slot count (1 for a stack), which otherwise made the plugin think it had a single coin and loop back to banking.Pay (tree patch)/Pay (Fruit tree)rather than a genericPay; the plugin finds them by name + specific action so checked/old trees actually get cleared.Chop downaction and clears it through the gardener.needsDowngradeflag to prevent an infinite re-downgrade loop.Testing
Verified live via the agent server: contract pickup, tree clearing by paying Rosie, contract turn-in, and the re-rake/seed-consumption planting path.