Skip to content

fix(AutoBankStander): herblore turbo cleaning + potion-making stall/timing fixes#492

Open
runsonmypc wants to merge 2 commits into
chsami:developmentfrom
runsonmypc:herblore-cleaning-rewrite
Open

fix(AutoBankStander): herblore turbo cleaning + potion-making stall/timing fixes#492
runsonmypc wants to merge 2 commits into
chsami:developmentfrom
runsonmypc:herblore-cleaning-rewrite

Conversation

@runsonmypc

Copy link
Copy Markdown
Contributor

Summary

AutoBankStander herblore improvements (v1.0.3):

  • Turbo cleaning mode (hidden config): rapid-clicks the whole grimy-herb inventory with Gaussian inter-batch sleep tuning (configurable min/max/target + optional auto-disable limit).
  • Fix potion-making stall: removed the stale currentlyMakingPotions flag. It was never reset when handleProcessing() transitioned back to banking, so after re-withdrawing ingredients process() spun on "Still making potions" at 0ms until the 30s state-timeout reset — losing ~30s per inventory. Crafting state is now derived from the existing animation guard + inventory checks (no invented state flag).
  • Fix slow make-all on finished/super-combat potions: the finished-potion paths waited on hasQuestion("How many do you wish to make?"), which never matches the make interface (widget group 270), so the sleepUntil always burned the full 3000ms before pressing make-all. Switched to hasCombinationDialogue(), matching the working unfinished-potions path (~3s faster per batch).

Testing

Verified live in the debug client (members, Herblore 49):

  • Unfinished potions (Harralander): multiple clean bank→craft→bank cycles with no Still making potions spin and no 30s timeout resets.
  • Finished potions (Energy): combine→make-all latency dropped from ~5s to ~2s, matching the unfinished path.

Remove the stale currentlyMakingPotions flag: it was never reset when
handleProcessing() transitioned to banking, so after re-withdrawing
ingredients process() spun on "Still making potions" at 0ms until the
30s state-timeout reset. Crafting state is now derived from the existing
animation guard + inventory checks.

Use Rs2Dialogue.hasCombinationDialogue() (widget group 270) instead of
hasQuestion("How many do you wish to make?") in the finished/super-combat
potion paths, matching the working unfinished-potions path. The question
text never matched the make interface, so the 3000ms sleepUntil always
timed out before pressing make-all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant