fix(AutoBankStander): herblore turbo cleaning + potion-making stall/timing fixes#492
Open
runsonmypc wants to merge 2 commits into
Open
fix(AutoBankStander): herblore turbo cleaning + potion-making stall/timing fixes#492runsonmypc wants to merge 2 commits into
runsonmypc wants to merge 2 commits into
Conversation
… sleep tuning Bump version to 1.0.3.
Remove the stale currentlyMakingPotions flag: it was never reset when
handleProcessing() transitioned to banking, so after re-withdrawing
ingredients process() spun on "Still making potions" at 0ms until the
30s state-timeout reset. Crafting state is now derived from the existing
animation guard + inventory checks.
Use Rs2Dialogue.hasCombinationDialogue() (widget group 270) instead of
hasQuestion("How many do you wish to make?") in the finished/super-combat
potion paths, matching the working unfinished-potions path. The question
text never matched the make interface, so the 3000ms sleepUntil always
timed out before pressing make-all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AutoBankStander herblore improvements (v1.0.3):
currentlyMakingPotionsflag. It was never reset whenhandleProcessing()transitioned back to banking, so after re-withdrawing ingredientsprocess()spun on"Still making potions"at 0ms until the 30s state-timeout reset — losing ~30s per inventory. Crafting state is now derived from the existing animation guard + inventory checks (no invented state flag).hasQuestion("How many do you wish to make?"), which never matches the make interface (widget group 270), so thesleepUntilalways burned the full 3000ms before pressing make-all. Switched tohasCombinationDialogue(), matching the working unfinished-potions path (~3s faster per batch).Testing
Verified live in the debug client (members, Herblore 49):
Still making potionsspin and no 30s timeout resets.