fix(barbarianfishing): replace isInteracting, add Rs2DropUtils#487
Open
runsonmypc wants to merge 1 commit into
Open
fix(barbarianfishing): replace isInteracting, add Rs2DropUtils#487runsonmypc wants to merge 1 commit into
runsonmypc wants to merge 1 commit into
Conversation
chsami
reviewed
Jun 16, 2026
chsami
left a comment
Owner
There was a problem hiding this comment.
I did not merge this because GitHub reports merge conflicts against development. Please resolve the conflicts and rerun checks; after that it can be reviewed for approval/merge. I did not approve while it is in a conflicting state.
Owner
|
Left open for now: this PR currently has merge conflicts against development. Please resolve the conflicts and rerun checks, then it can be reviewed/merged. |
d4ad9c2 to
389bcc5
Compare
…g, add Rs2DropUtils Replace unreliable isInteracting() check with isAnimating(timeout) and isMoving() using randomized timeouts via Rs2Random.truncatedGauss. Add Rs2DropUtils for humanized item dropping with per-session pace variance and sped-up natural mouse. Fix stale state on plugin restart, spec activation edge cases, and inventory full detection order.
389bcc5 to
e6c02da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rs2Player.isInteracting()withisAnimating(timeout)/isMoving()using randomized timeouts viaRs2Random.truncatedGaussfor more reliable fishing state detectionRs2DropUtilsutility with humanized item dropping — per-session pace seed, log-normal jitter, and sped-up natural mouse during drop sequencesspecReadyTime,specActivated,animationTimeoutinrun())gaussRanddelays, checksetSpecStatereturn valueisFull()beforeactionCooldownActiveso drops aren't blocked by antiban cooldownonGameTick()plumbing, duplicateversionfield, unusedtimeoutfieldshutDown()null guard for overlay manager (symmetric withstartUp())Test plan