Skip to content

fix(barbarianfishing): replace isInteracting, add Rs2DropUtils#487

Open
runsonmypc wants to merge 1 commit into
chsami:developmentfrom
runsonmypc:fix/barbarian-fishing
Open

fix(barbarianfishing): replace isInteracting, add Rs2DropUtils#487
runsonmypc wants to merge 1 commit into
chsami:developmentfrom
runsonmypc:fix/barbarian-fishing

Conversation

@runsonmypc

Copy link
Copy Markdown
Contributor

Summary

  • Replace Rs2Player.isInteracting() with isAnimating(timeout) / isMoving() using randomized timeouts via Rs2Random.truncatedGauss for more reliable fishing state detection
  • Add shared Rs2DropUtils utility with humanized item dropping — per-session pace seed, log-normal jitter, and sped-up natural mouse during drop sequences
  • Fix stale state on plugin restart (reset specReadyTime, specActivated, animationTimeout in run())
  • Fix spec activation edge cases: clamp negative gaussRand delays, check setSpecState return value
  • Fix inventory full detection: check isFull() before actionCooldownActive so drops aren't blocked by antiban cooldown
  • Drop filter now includes roe and caviar byproducts
  • Remove dead code: onGameTick() plumbing, duplicate version field, unused timeout field
  • Add try-catch around scheduled executor lambda to prevent silent task death
  • Add shutDown() null guard for overlay manager (symmetric with startUp())
  • Bump plugin version to 1.1.0

Test plan

  • Enable Barbarian Fisher plugin and verify fishing starts correctly
  • Verify script recovers when fishing spot disappears (no stuck "busy" state)
  • Verify inventory drops correctly when full (including roe/caviar)
  • Verify drop speed is noticeably faster than stock with natural mouse still moving
  • Stop and restart the plugin — verify no stale state issues
  • Verify dragon harpoon special attack timing works correctly

@chsami chsami left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not merge this because GitHub reports merge conflicts against development. Please resolve the conflicts and rerun checks; after that it can be reviewed for approval/merge. I did not approve while it is in a conflicting state.

@chsami

chsami commented Jun 16, 2026

Copy link
Copy Markdown
Owner

Left open for now: this PR currently has merge conflicts against development. Please resolve the conflicts and rerun checks, then it can be reviewed/merged.

@runsonmypc runsonmypc force-pushed the fix/barbarian-fishing branch from d4ad9c2 to 389bcc5 Compare June 16, 2026 21:34
…g, add Rs2DropUtils

Replace unreliable isInteracting() check with isAnimating(timeout) and
isMoving() using randomized timeouts via Rs2Random.truncatedGauss. Add
Rs2DropUtils for humanized item dropping with per-session pace variance
and sped-up natural mouse. Fix stale state on plugin restart, spec
activation edge cases, and inventory full detection order.
@runsonmypc runsonmypc force-pushed the fix/barbarian-fishing branch from 389bcc5 to e6c02da Compare June 16, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants