fix(karambwan): Zanaris fairy ring, remove isInteracting, deposit scrollboxes#485
Merged
Merged
Conversation
… scrollboxes - Filter Zanaris fairy ring query by FAIRY_RING_ID instead of grabbing nearest untyped tile object (was clicking wrong object) - Remove broken isInteracting() gate from fishing loop - Add scrollbox depositing during banking
… deposit scrollboxes
- Fix Zanaris fairy ring: correct object ID (29560), coordinate (4434 not
4435), and action text ("Last-destination" not "Last-destination (DKP)")
- Use tile object cache with nearestOnClientThread() — Rs2GameObject.getAll()
does not find the Zanaris fairy ring
- Remove broken isInteracting() check from fishing loop (upstream unreliable)
- Add scrollbox depositing during banking
- Bump version to 1.2.1
chsami
approved these changes
Jun 16, 2026
chsami
left a comment
chsami
left a comment
Owner
There was a problem hiding this comment.
Reviewed for critical/security issues, malicious code, and plugin version bump. No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rs2GameObject.getAll()— must use the tile object cache withnearestOnClientThread().isInteracting()check from the fishing loop — unreliable upstream, was gated with||so it never actually prevented re-clicking.Test plan