fix(channels): resolve false WhatsApp unpaired status when selfChatMode is false#87
Merged
Merged
Conversation
…de is false Signed-off-by: kesslerio <martin@kessler.io>
…pp status Signed-off-by: kesslerio <martin@kessler.io>
kesslerio
force-pushed
the
fix/whatsapp-pairing-status
branch
from
915bd0d to
71d5613
Compare
chrysb
approved these changes
Jun 11, 2026
chrysb
left a comment
chrysb
left a comment
Owner
There was a problem hiding this comment.
Looks good. The shared pairing-count helper preserves the WhatsApp selfChatMode=false case while keeping the existing gateway/agents status paths aligned. Targeted gateway and agents-service tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves the issue where a paired WhatsApp channel was incorrectly displayed as "Awaiting pairing" in the UI when
selfChatModewas set tofalse.Changes
hasSavedWhatsAppCredentialsto check for the presence of WhatsApp session files before treating the account as paired.selfChatMode === falseguard tohasImplicitWhatsAppSelfPairing. Instead, WhatsApp now counts allowed numbers (allowFromentries) if valid credentials exist, correctly reflecting pairing status.listConfiguredChannelAccounts(shared) andgetChannelStatus(gateway) to follow the same pairing check logic for WhatsApp.Verification
tests/server/gateway.test.jsverifying that:pairedifselfChatMode: false, credentials exist, andallowFromis populated.configured(unpaired) ifselfChatMode: false, credentials exist, butallowFromis empty.npx vitest run) to confirm clean execution.