linux: Draw shadows and rounded corners for frameless windows#4181
linux: Draw shadows and rounded corners for frameless windows#4181aiddya wants to merge 1 commit into
Conversation
Review CommentsGood approach overall — extending
The overlay offset fix via |
|
Introduce CaptionlessFrameViewLinux to draw shadows and rounded corners for frameless windows on Linux. This matches the behavior of frameless windows on macOS and Windows. CaptionlessFrameViewLinux extends FrameViewLinux to suppress the titlebar and round all four corners. Corner radii propagate from the frame view to the client view, which rounds the hosted web contents. Overlay positioning is offset by the new frame border insets so overlays stay within the client area.
6e06c31 to
df67ebe
Compare
|
Removed epsilon and expanded tests to X11 with compositing support. |
|
@magreenblatt Can you please take another look at this? I want to land this in 7871 if possible. |
Introduce CaptionlessFrameViewLinux to draw shadows and rounded corners for frameless windows on Linux. This matches the behavior of frameless windows on macOS and Windows.
CaptionlessFrameViewLinux extends FrameViewLinux to suppress the titlebar and round all four corners. Corner radii propagate from the frame view to the client view, which rounds the hosted web contents. Overlay positioning is offset by the new frame border insets so overlays stay within the client area.